[ 
https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597279#comment-13597279
 ] 

Kihwal Lee commented on HDFS-4567:
----------------------------------

The patch looks good. The change prevents unconditional pre-acquisition of 
tokens, but do acquire a token for non-token related operations. 

There is slight change in behavior. If the file system instance is created, but 
no operation is done for long enough to expire tgt in the ticket cache, it 
won't be usable any more. Previously, pre-acquired token could outlast tgt and 
allow the file system to be used. But this change of behavior will only matter 
if ticket cache is used, not keytab and a WebHdfsFileSystem instance is 
created, but unused for a long time. Since services typically use keytab, this 
will mostly be confined to user interactive sessions and scripts where users 
need to make sure a valid tgt is present and the file system is used right 
away. Overall, there should be no visible negative effect.

+1 
                
> Webhdfs does not need a token for token operations
> --------------------------------------------------
>
>                 Key: HDFS-4567
>                 URL: https://issues.apache.org/jira/browse/HDFS-4567
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: webhdfs
>    Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-4567.branch-23.patch, HDFS-4567.branch-23.patch, 
> HDFS-4567.patch, HDFS-4567.patch
>
>
> Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even 
> though it neither needs nor uses the token.  The implicit token triggers a 
> renewer thread for the fs which is undesirable for daemons such as oozie and 
> yarn's RM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to