[ 
https://issues.apache.org/jira/browse/HDFS-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597343#comment-13597343
 ] 

Kihwal Lee commented on HDFS-4577:
----------------------------------

The patch looks straightforward. The individual op had no knowledge of its auth 
requirement, but now they do. This doesn't seem to decrease flexibility in any 
manner, so I think moving this check to the op level is okay.  

+1 pending successful precommit.
                
> Webhdfs operations should declare if authentication is required
> ---------------------------------------------------------------
>
>                 Key: HDFS-4577
>                 URL: https://issues.apache.org/jira/browse/HDFS-4577
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: webhdfs
>    Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-4577.branch-23.patch, HDFS-4577.patch
>
>
> Multiple hardcoded conditionals for operations can be avoided in webhdfs if 
> the methods declare if authentication (ie. cannot use a token) is required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to