[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597813#comment-13597813 ]
Ivan Mitic commented on HDFS-4572: ---------------------------------- Patch looks good, +1 One question though, I see that you're adding a timeout to every test case in the test. Is this a new guideline? I found it hard to debug tests like these and always ended up removing the timeout what seemed a bit odd. Would it make more sense to have a test wide 15 minute timeout or something? Ideally, the timeout would be configured from the outside and not hit when debugging from eclipse. > Fix TestJournal failures on Windows > ----------------------------------- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test > Affects Versions: 3.0.0 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira