[ 
https://issues.apache.org/jira/browse/HDFS-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613300#comment-13613300
 ] 

Aaron T. Myers commented on HDFS-4489:
--------------------------------------

bq. One of the main reasons for a feature branch (at least for me), while 
during development, we may break trunk. But in this case that is not the case.

At one point in time I believe the INodeID work did indeed break WebHDFS on 
trunk.

Another reason for using a development branch is because the feature isn't 
necessarily complete without certain patches having been committed. The fact 
that HDFS-4339 (persist INodeIDs in the fsimage) isn't committed yet suggests 
that this feature won't really work as-intended until that's committed, but yet 
we've already committed other patches involving INodeIDs to trunk. That doesn't 
make much sense to me.

I don't understand the resistance to doing this on a feature branch. What's the 
concern with doing so?
                
> Use InodeID as as an identifier of a file in HDFS protocols and APIs
> --------------------------------------------------------------------
>
>                 Key: HDFS-4489
>                 URL: https://issues.apache.org/jira/browse/HDFS-4489
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>
> The benefit of using InodeID to uniquely identify a file can be multiple 
> folds. Here are a few of them:
> 1. uniquely identify a file cross rename, related JIRAs include HDFS-4258, 
> HDFS-4437.
> 2. modification checks in tools like distcp. Since a file could have been 
> replaced or renamed to, the file name and size combination is no t reliable, 
> but the combination of file id and size is unique.
> 3. id based protocol support (e.g., NFS)
> 4. to make the pluggable block placement policy use fileid instead of 
> filename (HDFS-385).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to