[ 
https://issues.apache.org/jira/browse/HDFS-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-4635:
----------------------------------

    Attachment: HDFS-4635.patch

bq. For percentage parameter, I think it is better to use a double with range 
[0.0, 1.0] than an int. We may call it "fraction" as well.
I feel percentage is better than fraction and easy to understand. I changed 
percentage to double.

All other comments addressed.
                
> Move BlockManager#computeCapacity to LightWeightGSet
> ----------------------------------------------------
>
>                 Key: HDFS-4635
>                 URL: https://issues.apache.org/jira/browse/HDFS-4635
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-4635.patch, HDFS-4635.patch
>
>
> The computeCapacity in BlockManager that calculates the LightWeightGSet 
> capacity as the percentage of total JVM memory should be moved to 
> LightWeightGSet. This helps in other maps that are based on the GSet to make 
> use of the same functionality.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to