[ https://issues.apache.org/jira/browse/HDFS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-4661: --------------------------------------- Attachment: HDFS-4661.004.patch > code style fixes suggested by Nicholas > -------------------------------------- > > Key: HDFS-4661 > URL: https://issues.apache.org/jira/browse/HDFS-4661 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, hdfs-client, performance > Reporter: Colin Patrick McCabe > Priority: Minor > Attachments: HDFS-4661.001.patch, HDFS-4661.002.patch, > HDFS-4661.003.patch, HDFS-4661.004.patch > > > * The log statement in DataXceiver > "BlockSender.ClientTraceLog.info("REQUEST_SHORT_CIRCUIT_FDS"...)" could be > cleaned up somewhat. > * use {{FsDatasetSpi#getBlockInputStream}} and > {{FsDatasetSpi#getMetaDataInputStream}} rather than adding > {{FsDatasetSpi#getShortCircuitFdsForRead}} > * {{FileInputStreamCache.Key.equals}}: use short-circuit boolean AND > * In FileInputStreamCache.CacheCleaner, the code "iter = > map.entries().iterator()" can be removed with the same result since the > (previous) first element must be removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira