[
https://issues.apache.org/jira/browse/HDFS-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630715#comment-13630715
]
Hadoop QA commented on HDFS-4639:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578503/HDFS-4639.trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4237//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4237//console
This message is automatically generated.
> startFileInternal() should not increment generation stamp
> ---------------------------------------------------------
>
> Key: HDFS-4639
> URL: https://issues.apache.org/jira/browse/HDFS-4639
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.0.3-alpha
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Attachments: HDFS-4639.patch, HDFS-4639.patch, HDFS-4639.patch,
> HDFS-4639.trunk.patch
>
>
> startFileInternal() increments genStamp and passes it to
> FSDirectory.addFile() as a parameter, while the addFile() simply ignores the
> generationStamp parameter.
> We should remove the call of nextGenerationStamp() in startFileInternal() and
> eliminate the redundant parameter in FSDirectory.addFile().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
