[ https://issues.apache.org/jira/browse/HDFS-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641284#comment-13641284 ]
Hadoop QA commented on HDFS-4748: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580420/HDFS-4748.1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4314//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4314//console This message is automatically generated. > MiniJournalCluster#restartJournalNode leaks resources, which causes sporadic > test failures > ------------------------------------------------------------------------------------------ > > Key: HDFS-4748 > URL: https://issues.apache.org/jira/browse/HDFS-4748 > Project: Hadoop HDFS > Issue Type: Bug > Components: qjm, test > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4748.1.patch > > > {{MiniJournalCluster#restartJournalNode}} stops a {{JournalNode}} and then > recreates a new one with the same configuration. However, it does not > maintain a reference to the new {{JournalNode}} instance, so therefore it > doesn't get stopped inside {{MiniJournalCluster#shutdown}}. The > {{JournalNode}} holds a file lock on its underlying storage, so this can > cause sporadic failures in tests like {{TestQuorumJournalManager}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira