[ https://issues.apache.org/jira/browse/HDFS-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-4777: ---------------------------------- Attachment: HDFS-4777.patch Changes in the patch: # I am going to make a change I was planning to do for a long time. The attached patch has an assert which fails when editlog sync is called with either FSNamesystem read or write lock held. This should help in catching any accidental introduction of code which calls logSync in critical sections. # This patch also modifies TestFileCreation to create a file with overwrite flag set when a file of that name already exists. This should trigger the logSync assert to fail. In a subsequent patch, I am going to post a fix with which the test failure should not occur. > File creation with overwrite flag set to true results in logSync holding > namesystem lock > ---------------------------------------------------------------------------------------- > > Key: HDFS-4777 > URL: https://issues.apache.org/jira/browse/HDFS-4777 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 0.23.0, 2.0.0-alpha > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Priority: Blocker > Attachments: HDFS-4777.patch > > > FSNamesystem#startFileInternal calls delete. Delete method releases the write > lock, making parts of startFileInternal code unintentionally executed without > write lock being held. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira