[ 
https://issues.apache.org/jira/browse/HDFS-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651333#comment-13651333
 ] 

Aaron T. Myers commented on HDFS-4804:
--------------------------------------

+1, the patch looks good to me. I'm going to commit this momentarily.
                
> WARN when users set the block balanced preference percent below 0.5 or above 
> 1.0
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-4804
>                 URL: https://issues.apache.org/jira/browse/HDFS-4804
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.4-alpha
>            Reporter: Stephen Chu
>            Assignee: Stephen Chu
>            Priority: Minor
>         Attachments: HDFS-4804.patch
>
>
> With the new feature added in HDFS-1804 (Add a new block-volume device 
> choosing policy that looks at free space), it'd be useful to have a WARN log 
> if the operator  sets 
> dfs.datanode.fsdataset.volume.choosing.balanced-space-preference-percent to a 
> value greater than 1.0. This might happen if the operator mistakenly assumes 
> that this setting takes in a percentage number from 0.0-100.0, while the 
> setting actually takes a range 0.0-1.0.
> Also, it'd be useful to WARN in the case that value is set below 0.5, which 
> would cause disks with less free space to get more block allocations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to