[ https://issues.apache.org/jira/browse/HDFS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-4661: --------------------------------- Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available) I've just committed this to trunk based on Nicholas's +1. Thanks a lot for the contribution, Colin. > fix various bugs in short circuit read > -------------------------------------- > > Key: HDFS-4661 > URL: https://issues.apache.org/jira/browse/HDFS-4661 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, hdfs-client > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Fix For: 3.0.0 > > Attachments: HDFS-4661.001.patch, HDFS-4661.002.patch, > HDFS-4661.003.patch, HDFS-4661.004.patch > > > - For the log statement in DataXceiver below, > -* it has two String.format(..); > -* it uses %s for string constants. > {code} > BlockSender.ClientTraceLog.info(String.format( > String.format( > "src: %s, dest: %s, op: %s, blockid: %s, srvID: %s, " + > "success: %b", > "127.0.0.1", // src IP > "127.0.0.1", // dst IP > "REQUEST_SHORT_CIRCUIT_FDS", // operation > blk.getBlockId(), // block id > dnR.getStorageID(), > (fis != null) > ))); > {code} > - The new method getShortCircuitFdsForRead(..) added to FsDatasetSpi is > unecssary. > - {{FileInputStreamCache.Key.equals}} mistakenly uses & instead of &&. > - In FileInputStreamCache.CacheCleaner, it uncessarily call > map.entries().iterator()) for each loop. > - The cache objects should not be passed in BlockReader.close(..) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira