[ https://issues.apache.org/jira/browse/HDFS-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660695#comment-13660695 ]
Hudson commented on HDFS-4824: ------------------------------ Integrated in Hadoop-Hdfs-trunk #1401 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1401/]) HDFS-4824. FileInputStreamCache.close leaves dangling reference to FileInputStreamCache.cacheCleaner. Contributed by Colin Patrick McCabe. (Revision 1483641) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1483641 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/FileInputStreamCache.java > FileInputStreamCache.close leaves dangling reference to > FileInputStreamCache.cacheCleaner > ----------------------------------------------------------------------------------------- > > Key: HDFS-4824 > URL: https://issues.apache.org/jira/browse/HDFS-4824 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client > Affects Versions: 2.0.4-alpha > Reporter: Henry Robinson > Assignee: Colin Patrick McCabe > Fix For: 3.0.0, 2.0.5-beta > > Attachments: HDFS-4824.001.patch, HDFS-4824.002.patch > > > {{FileInputStreamCache}} leaves around a reference to its {{cacheCleaner}} > after {{close()}}. > The {{cacheCleaner}} is created like this: > {code} > if (cacheCleaner == null) { > cacheCleaner = new CacheCleaner(); > executor.scheduleAtFixedRate(cacheCleaner, expiryTimeMs, > expiryTimeMs, > TimeUnit.MILLISECONDS); > } > {code} > and supposedly removed like this: > {code} > if (cacheCleaner != null) { > executor.remove(cacheCleaner); > } > {code} > However, {{ScheduledThreadPoolExecutor.remove}} returns a success boolean > which should be checked. And I _think_ from a quick read of that class that > the return value of {{scheduleAtFixedRate}} should be used as the argument to > {{remove}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira