[ https://issues.apache.org/jira/browse/HDFS-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668387#comment-13668387 ]
Daryn Sharp commented on HDFS-4780: ----------------------------------- The change to the callers to invoke the "check" version seems ok. It looks like the more appropriate UGI change may be to modify by {{reloginFromKeytab}} to switch the order of {{hasSufficientTimeElapsed}} (which generates the warning) and {{getRefreshTime}} which shorts out the renew attempt. On a related note, the two relogin methods appear equivalent aside from the {{hasSufficientTimeElapsed}} check. It would seem that only {{checkTGTAndReloginFromKeytab}} should be checking {{getRefreshTime}}. {{reloginFromKeytab}} should be probably be unconditionally re-acquiring a TGT, hence not checking {{hasSufficientTimeElapsed}}. > Use the correct relogin method for services > ------------------------------------------- > > Key: HDFS-4780 > URL: https://issues.apache.org/jira/browse/HDFS-4780 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 3.0.0, 2.0.5-beta, 0.23.8 > Reporter: Kihwal Lee > Assignee: Robert Parker > Priority: Minor > Fix For: 3.0.0, 2.0.5-beta > > Attachments: HDFS-4780-branch0.23v1.patch, HDFS-4780v1.patch > > > A number of components call reloginFromKeytab() before making requests. For > StandbyCheckpointer and SecondaryNameNode, where this can be called > frequently, it generates many WARN messages like this: > WARN security.UserGroupInformation: Not attempting to re-login since the last > re-login was attempted less than 600 seconds before. > Other than these messages, it doesn't do anything wrong. But it will be nice > if it is changed to call checkTGTAndReloginFromKeytab() to avoid the > potentially misleading WARN messages. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira