[ https://issues.apache.org/jira/browse/HDFS-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671797#comment-13671797 ]
Todd Lipcon commented on HDFS-4867: ----------------------------------- It seems to me that metasave should just be a "read" operation, and not modify the queue even if it detects that it's an invalid block. I'd vote for just logging it with an "[orphaned]" or something like that. > metaSave NPEs when there are invalid blocks in repl queue. > ---------------------------------------------------------- > > Key: HDFS-4867 > URL: https://issues.apache.org/jira/browse/HDFS-4867 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 0.23.7, 2.0.4-alpha > Reporter: Kihwal Lee > Assignee: Ravi Prakash > > Since metaSave cannot get the inode holding a orphaned/invalid block, it NPEs > and stops generating further report. Normally ReplicationMonitor removes them > quickly, but if the queue is huge, it takes very long time. Also in safe > mode, they stay. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira