[ 
https://issues.apache.org/jira/browse/HDFS-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679289#comment-13679289
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4873:
----------------------------------------------

> ... However, here maybe we still should return the status of a snapshot file 
> as a closed file since our snapshot is read-only? 

I think it is a good idea.  Let's do it.

Some other nites:

- In FSNamesystem, inSnapshot is the same as iip.isSnapshot() so that we don't 
need the new boolean variable.

- No need to change AbstractINodeDiff.getSnapshotINode() to public.
                
> callGetBlockLocations returns incorrect number of blocks for snapshotted files
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-4873
>                 URL: https://issues.apache.org/jira/browse/HDFS-4873
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Hari Mankude
>            Assignee: Jing Zhao
>         Attachments: HDFS-4873.001.patch
>
>
> callGetBlockLocations() returns all the blocks of a file even when they are 
> not present in the snap version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to