[
https://issues.apache.org/jira/browse/HDFS-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680096#comment-13680096
]
Konstantin Shvachko commented on HDFS-4878:
-------------------------------------------
Strictly speaking we should decrementReplicationIndex() if we remove the block
at a position before the replicationIndex, and should not decrement if the
block position is after the replicationIndex. In general we don't know the
position of the block in the queue, so we cannot know whether the index should
be decremented.
It should be targeted in a different jira if desired. The worst thing that
happens if we don't change replicationIndex is that some blocks will be
replicated later, which happens with some blocks one way or another. Eventually
everything will be processed and that is what's important.
I'd rather commit the original patches.
> On Remove Block, Block is not Removed from neededReplications queue
> -------------------------------------------------------------------
>
> Key: HDFS-4878
> URL: https://issues.apache.org/jira/browse/HDFS-4878
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Tao Luo
> Assignee: Tao Luo
> Fix For: 3.0.0
>
> Attachments: HDFS-4878_branch2.patch, HDFS-4878.patch, HDFS-4878.patch
>
>
> Remove block removes the specified block from pendingReplications, but not
> from neededReplications queue.
> The fix would be to remove from neededReplications as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
