[
https://issues.apache.org/jira/browse/HDFS-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682421#comment-13682421
]
Konstantin Boudnik commented on HDFS-4849:
------------------------------------------
Wow, hefty tests... The patch looks good - seems to be addressing everything as
discussed above.
+1 with two minor improvements to make:
This seems like a formatting change to me
{noformat}
- // Now we can add the name to the filesystem. This file has no
- // blocks associated with it.
- //
- checkFsObjectLimit();
+ // Now we can add the name to the filesystem. This file has no
+ // blocks associated with it.
+ //
+ checkFsObjectLimit();
{noformat}
I understand that originally it was misaligned, but it doesn't look like a part
of the fix.
another whitespace change
{noformat}
+
+ /**
+ * Check if create or append call is a retry.e
{noformat}
I've looked into the failing tests - they look irrelevant to the change.
> Idempotent create and append operations.
> ----------------------------------------
>
> Key: HDFS-4849
> URL: https://issues.apache.org/jira/browse/HDFS-4849
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.0.4-alpha
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Attachments: idempotentCreate.patch, idempotentCreate.patch
>
>
> create, append and delete operations can be made idempotent. This will reduce
> chances for a job or other app failures when NN fails over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
