[ 
https://issues.apache.org/jira/browse/HDFS-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683890#comment-13683890
 ] 

Hadoop QA commented on HDFS-4866:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12587900/HDFS-4866.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/4521//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4521//console

This message is automatically generated.
                
> Protocol buffer support cannot compile under C
> ----------------------------------------------
>
>                 Key: HDFS-4866
>                 URL: https://issues.apache.org/jira/browse/HDFS-4866
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Ralph Castain
>            Assignee: Arpit Agarwal
>            Priority: Blocker
>         Attachments: HDFS-4866.002.patch, HDFS-4866.branch-2.001.patch, 
> HDFS-4866.trunk.001.patch, NamenodeProtocol.pb-c.c, NamenodeProtocol.pb-c.h, 
> pcreate.pl
>
>
> When compiling Hadoop's .proto descriptions for use in C, an error occurs 
> because one of the RPC's in NamenodeProtocol.proto is named "register". This 
> name is a reserved word in languages such as C. When using the Java and C++ 
> languages, the name is hidden inside a class and therefore doesn't cause an 
> error. Unfortunately, that is not the case in non-class languages such as C.
> Note: generating the C translation of the .proto files requires installation 
> of the protobuf-c package from google:
> http://code.google.com/p/protobuf-c/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to