[ https://issues.apache.org/jira/browse/HDFS-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Prakash updated HDFS-4888: ------------------------------- Attachment: HDFS-4888.patch Hi Kihwal! Thanks for reviewing the patch. By automatic safemode I meant the NN will come out of safemode automatically. I've clarified that comment in this new patch. I feel we should print out the datanodeThreshold and the current number of datanodes even if the threshhold is set to 0. Removal of the condition was deliberate as I noted in my earlier comment's point 2. Oh cool! So we can actually fix a bug with this JIRA and its not a simple refactor. Swell. Thanks Kihwal! :-) This patch makes that change. > Refactor and fix FSNamesystem.getTurnOffTip to sanity > ----------------------------------------------------- > > Key: HDFS-4888 > URL: https://issues.apache.org/jira/browse/HDFS-4888 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.0.0, 2.0.4-alpha, 0.23.9 > Reporter: Ravi Prakash > Assignee: Ravi Prakash > Attachments: HDFS-4888.patch, HDFS-4888.patch, HDFS-4888.patch > > > e.g. When resources are low, the command to leave safe mode is not printed. > This method is unnecessarily complex -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira