[ 
https://issues.apache.org/jira/browse/HDFS-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702655#comment-13702655
 ] 

Jing Zhao commented on HDFS-4373:
---------------------------------

The patch looks good to me. Some minors:

1. Based on the current changes in HDFS-4372, 
StartupProgressServlet#putIfNotNull may need to be updated since we no longer 
use Long and null for regular and uninitialized fields of Step.
2. In StartupProgressServlet, instead of putting all the information contained 
in a StartupProgressView into a newly-created map and converting the map into 
Json, can we directly dump the StartupProgressView instance into the response's 
writer using Json (just like Configuration#dumpConfiguration)?
3. We can clean the imports in both TestStartupProgressServlet.java and 
StartupProgressServlet.java
                
> Add HTTP API for querying NameNode startup progress
> ---------------------------------------------------
>
>                 Key: HDFS-4373
>                 URL: https://issues.apache.org/jira/browse/HDFS-4373
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-4373.1.patch
>
>
> Provide an HTTP API for non-browser clients to query the NameNode's current 
> progress through startup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to