[ 
https://issues.apache.org/jira/browse/HDFS-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712126#comment-13712126
 ] 

Jing Zhao commented on HDFS-5007:
---------------------------------

Thanks for the code cleaning Kousuke! How about merging HDFS-5002 to this jira, 
i.e., also removing the unused/duplicated DFSConfigKeys fields in this patch?
                
> the property key "dfs.http.port" and "dfs.https.port" are hard corded
> ---------------------------------------------------------------------
>
>                 Key: HDFS-5007
>                 URL: https://issues.apache.org/jira/browse/HDFS-5007
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Kousuke Saruta
>             Fix For: 3.0.0
>
>         Attachments: HDFS-5007.patch
>
>
> In "TestHftpFileSystem.java" and "NameNodeHttpServer.java" , the two property 
> key "dfs.http.port" and "dfs.https.port" are hard corded.
> Now, the constant values "DFS_NAMENODE_HTTP_PORT_KEY" and 
> "DFS_NAMENODE_HTTPS_KEY" in DFSConfigKeys are available so I think we should 
> replace those for maintainability. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to