[ 
https://issues.apache.org/jira/browse/HDFS-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725493#comment-13725493
 ] 

Jing Zhao commented on HDFS-4926:
---------------------------------

The current patch looks good to me. I built and ran locally and the new WebUI 
looks good. Only one nit:
{code}
+          + ((alive) ? "" : "\n") + "<td class=\"address\">" + d.getIpAddr()
+          + ":" + d.getXferPort());
{code}
Let's use "d.getXferAddr()" instead of "d.getIpAddr() + ":" + d.getXferPort()" 
here.

+1 with the change.
                
> namenode webserver's page has a tooltip that is inconsistent with the 
> datanode HTML link
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-4926
>                 URL: https://issues.apache.org/jira/browse/HDFS-4926
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Joseph Lorenzini
>            Assignee: Vivek Ganesan
>            Priority: Trivial
>         Attachments: HDFS-4926.patch
>
>
> At http://localhost:50070/dfsnodelist.jsp?whatNodes=LIVE, there is a list of 
> Live datanodes in a table.  In the Node column, there is a link to each node. 
> If you hover your cursor over one of the links, it shows the IP address and 
> port number of the datanode. However, actual link is the hostname instead of 
> the IP. 
> Suggest that the tooltip reflect the actual url that the web browser would go 
> to if the link is selected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to