[
https://issues.apache.org/jira/browse/HDFS-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746748#comment-13746748
]
Andrew Wang commented on HDFS-5052:
-----------------------------------
bq. Check the code calling listPathCacheEntries. startId is always one more
than the previous listed entry.
Interesting, I assumed it was the same as listStatus, which I believe uses the
last element. I guess this is a place where the ascending unique ID and a
TreeMap come in handy, though using the "last+1" kind of bakes it in. I'd
mildly prefer the same style as listStatus, since we can add 1 on the server
side.
bq. The user information is sent with each RPC already...
Yea, my point here was not that we need to put it in the protobuf, but that
we'll need to save it (along with ACLs or whatever) with the
PathCacheDirective. It'll all happen in that follow-on though.
bq. The server can't trust the client to do the right thing-- we have to verify
it for ourselves. Otherwise malicious clients could cause damage.
Yep, my point was that we already require paths to be absolute (see the
{{DFSUtil#isValidName}} check in {{DFS#getPathName}} and {{FSNamesystem}}.
Seems like the normalization is unnecessary since nothing else server side does
it, and maybe you could just call {{DFSUtil#isValidName}} to do the absolute
check (and more).
+1 once you address (either rev or reply) these comments, pretty minor. I'll
wait until tomorrow morning before committing to give others time to comment as
well.
> Add cacheRequest/uncacheRequest support to NameNode
> ---------------------------------------------------
>
> Key: HDFS-5052
> URL: https://issues.apache.org/jira/browse/HDFS-5052
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5052.003.patch, HDFS-5052.004.patch,
> HDFS-5052-caching.002.patch, HDFS-5052-caching.004.patch
>
>
> Add cacheRequest/uncacheRequest/listCacheRequest support to DFSAdmin and
> NameNode. Maintain a list of active CachingRequests on the NameNode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
