[ 
https://issues.apache.org/jira/browse/HDFS-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749200#comment-13749200
 ] 

Colin Patrick McCabe commented on HDFS-5121:
--------------------------------------------

* added Nonnull annotation to CachePool

bq. Eclipse is telling me these are unchecked casts:

I don't think there's any way around this-- it's just the way the RetryCache 
works.  {{CacheEntryWithPayload}} contains an object of type Object and you 
have to deal with casting.

bq. Rather than passing down pc, how about some new methods in 
FSPermissionChecker

I added some methods to FSPermissionChecker.  I didn't end up needing to pull 
in CachePool to that class-- passing in the user, group, and mode should be 
enough.

bq. No addCachePool API?

Yeah, I guess we should have one of those.
                
> add RPCs for creating and manipulating cache pools
> --------------------------------------------------
>
>                 Key: HDFS-5121
>                 URL: https://issues.apache.org/jira/browse/HDFS-5121
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-4949
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5121-caching.001.patch
>
>
> We should add RPCs for creating and manipulating cache pools.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to