[ 
https://issues.apache.org/jira/browse/HDFS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750141#comment-13750141
 ] 

Binglin Chang commented on HDFS-4667:
-------------------------------------

And another issue about symlink, currently the original code treat all symlink 
delete/create as modify, but symlink is immutable.
{code}
    if (cnode.isSymlink() && dnode.isSymlink()) {
        dList.add(new DiffReportEntry(DiffType.MODIFY, fullPath));
    } else {
{code}
In this patch, symlink with same name but different inodeid are treated as one 
CREATE and one DELETE

                
> Capture renamed files/directories in snapshot diff report
> ---------------------------------------------------------
>
>                 Key: HDFS-4667
>                 URL: https://issues.apache.org/jira/browse/HDFS-4667
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Binglin Chang
>         Attachments: getfullname-snapshot-support.patch, 
> HDFS-4667.demo.patch, HDFS-4667.v1.patch
>
>
> Currently in the diff report we only show file/dir creation, deletion and 
> modification. After rename with snapshots is supported, renamed file/dir 
> should also be captured in the diff report.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to