[
https://issues.apache.org/jira/browse/HDFS-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751573#comment-13751573
]
Arpit Agarwal commented on HDFS-4987:
-------------------------------------
I hit submit too soon.
{quote}
For #1, I tried to move blockContentsStale to be per storage but it is quite
involved. How about we move it when we change block report to be per storage?
{quote}
This sounds good. I filed HDFS-5134 to track this and couple of other items
that can be done per-storage now.
Javadoc nitpicks but I am +1 on the patch basically. Please feel free to commit
this today.
# {{BlockManager#processReport}} - Javadoc should be updated e.g. {{" * The
given datanode is reporting all its blocks on the given Storage.}}
# BlockInfo.java:44 - Comment should be updated to say {{"block belongs to
triplets[3*i] is the reference to the StorageInfo"}}
# {{BlockInfo#findStorageInfo}} - Parameter should be " {{* @param dn"}}
# {{BlockManager#addStoredBlockImmediate}} - Link in header comment needs to be
updated.
Thanks!
Arpit
> Namenode changes to track multiple storages
> -------------------------------------------
>
> Key: HDFS-4987
> URL: https://issues.apache.org/jira/browse/HDFS-4987
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Suresh Srinivas
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4987_20130822.patch, h4987_20130827b.patch,
> h4987_20130827c.patch, h4987_20130827.patch
>
>
> Currently namenode track in BlockInfo, the corresponding DataNodeDescriptor.
> I propose changing this with new abstraction StorageDescriptor. This change
> will also make DatanodeDescriptor a collection of StroageDescriptors. This
> will allow given a block, identify its storage and also Datanode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
