[ 
https://issues.apache.org/jira/browse/HDFS-5154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756133#comment-13756133
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-5154:
----------------------------------------------

Hi Jinping, it is great that you help fixing the tests!  Thanks a lot.

You are right that we shouldn't mark jira for specific branch as patch 
available since it will trigger Jenkins to incorrectly apply the patch to trunk.

My only comment to the patch is that the new methods added to DFSTestUtil could 
be moved to BlockManagerTestUtil.  Then, we don't need to change 
updateStorage(..) to public.
                
> Fix several tests failure after HDFS-4987
> -----------------------------------------
>
>                 Key: HDFS-5154
>                 URL: https://issues.apache.org/jira/browse/HDFS-5154
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: Heterogeneous Storage (HDFS-2832)
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: HDFS-5154-v1.patch
>
>
> HDFS-4987 add tracking multiple storage in NN which involve several UT 
> failures, i.e. TestBlockManager, TestDataNodeDescriptor, etc. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to