[ https://issues.apache.org/jira/browse/HDFS-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762506#comment-13762506 ]
Brandon Li commented on HDFS-5085: ---------------------------------- Some early comments: The patch introduced a new package org.apache.hadoop.security and you renamed some of its classes (NfsCredential from Credential) to avoid name conflict with the same security package class which already exists in Hadoop. Two org.apache.hadoop.security packages could cause problems even they are in different projects (hadoop-nfs and hadoop-common). To avoid confusing and have a better code organization, we can do one of the following: 1.rename org.apache.hadoop.security to org.apache.hadoop.rpcsecurity, only if you strongly feel security is not part of oncrpc. 2.move it into oncrpc package: org.apache.hadoop.oncrpc.security. > Refactor o.a.h.nfs to support different types of authentications > ---------------------------------------------------------------- > > Key: HDFS-5085 > URL: https://issues.apache.org/jira/browse/HDFS-5085 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs > Affects Versions: 3.0.0 > Reporter: Brandon Li > Assignee: Jing Zhao > Attachments: HDFS-5085.001.patch, HDFS-5085.002.patch > > > 1. Add Credentials and Verifier definitions. > 2. Update Nfs3Interface.java and add SessionSecurityHandler to allow the > support of different types of authentications. > 3. Update RpcProgrammNfs3.java to move the original AUTH_SYS authentication > into the new interfaces. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira