[ 
https://issues.apache.org/jira/browse/HDFS-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-5188:
-----------------------------------------

    Attachment: h5188_20130915.patch

Thanks Junping for reviewing the patch.

h5188_20130915.patch:
- removes DatanodeInfo.EMPTY_ARRAY;
- always creates debugLoggingBuilder like before for supporting changing log 
level at runtime.

For simple JIRAs, non-committer can review and +1 on patches.  Although the 
patch here is not small, I think this one is a simple JIRA since all changes 
are straightforward. If you are uncomfortable, I could find someone the review 
this.
                
> Clean up BlockPlacementPolicy and its implementations
> -----------------------------------------------------
>
>                 Key: HDFS-5188
>                 URL: https://issues.apache.org/jira/browse/HDFS-5188
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h5188_20130912b.patch, h5188_20130912.patch, 
> h5188_20130914.patch, h5188_20130915.patch
>
>
> Below is a list of code cleanup tasks for BlockPlacementPolicy and its 
> implementations:
> - Define constants for dfs.block.replicator.classname.
> - Combine adjustExcludedNodes and addToExcludedNodes: subclasses should 
> always add all the related nodes in addToExcludedNodes(..).
> - Remove duplicated code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to