[ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768006#comment-13768006 ]
Hadoop QA commented on HDFS-5207: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12603241/HDFS-5207-v1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4976//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4976//console This message is automatically generated. > In BlockPlacementPolicy, the type of writer in parameters of chooseTarget() > should be updated from DatanodeDescriptor to Node > ----------------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-5207 > URL: https://issues.apache.org/jira/browse/HDFS-5207 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Reporter: Junping Du > Assignee: Junping Du > Attachments: HDFS-5207-v1.patch > > > We should change chooseTarget(..., DatanodeDescriptor writer, ...) to > chooseTarget (..., node writer, ...) as the only important property of writer > is to identify other nodes' location relationship so more generic one could > be better. It also helps to cover cases that client node is not a Datanode > also. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira