[
https://issues.apache.org/jira/browse/HDFS-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth reassigned HDFS-4924:
-----------------------------------
Assignee: Lohit Vijayarenu
Hi, Lohit. It looks like this patch will need to be rebased. First, a few
comments:
# It would help the user experience if the terminology for HA state was
consistent between dfshealth.jsp and dfsclusterhealth.jsp. Instead of the
current {{getActiveState}} method, can we rename the method to {{getHAState}}
and have it return the value of
{{haContext.getState().getServiceState().toString()}}? We can guard for nulls
and map null to {{HAServiceState.INITIALIZING}}. This would match what is
displayed in the header of dfshealth.jsp.
# {{getNameNodeState}} currently overloads a single column to communicate both
safe mode and HA state. This could mislead or hide information. (For example,
there is the case of a NameNode that is active for HA, but manually placed in
safe mode via {{hdfs dfsadmin -safemode enter}}. Can we use 2 separate columns
for safe mode and HA state?
# There are a few typos in the {{ClusterJspHelper}} JavaDocs:
{code}
+ * Get redable state of NameNode. If NameNode is in Safemode,
+ * show that state, if not show Active/Standby state
+ * For NonHA mode, NameNode would be shown as Active
+ * For older version of NameNode state is shown as Unkown
{code}
I made an earlier comment about adding the NameNode role, which is also on
dfshealth.jsp. I can see how this would be more challenging to add, so feel
free to disregard that comment for now. If needed, we can always add it later
in a separate patch.
Thank you for working on this!
> Show NameNode state on dfsclusterhealth page
> --------------------------------------------
>
> Key: HDFS-4924
> URL: https://issues.apache.org/jira/browse/HDFS-4924
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: federation
> Affects Versions: 2.1.0-beta
> Reporter: Lohit Vijayarenu
> Assignee: Lohit Vijayarenu
> Priority: Minor
> Attachments: HDFS-4924.trunk.1.patch
>
>
> dfsclusterhealth.jsp shows summary of multiple namenodes in cluster. With
> federation combined with HA it becomes difficult to quickly know the state of
> NameNodes in the cluster. It would be good to show if NameNode is
> Active/Standy on summary page.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
