[ https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771624#comment-13771624 ]
Chris Nauroth commented on HDFS-5191: ------------------------------------- Passing null to mean "don't create fallback buffers" sounds fine. For "fallback fallback", it does sound useful for the {{ByteBufferPool}} to be able to provide a guaranteed array-backed {{ByteBuffer}}. Regarding impact of returning direct vs. non-direct buffers to clients, I think this is acceptable considering that it is part of the existing contract of {{ByteBuffer}}. Clients are expected to check {{hasArray}} before attempting array operations. > revisit zero-copy API in FSDataInputStream to make it more intuitive > -------------------------------------------------------------------- > > Key: HDFS-5191 > URL: https://issues.apache.org/jira/browse/HDFS-5191 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client, libhdfs > Affects Versions: HDFS-4949 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-5191-caching.001.patch, HDFS-5191-caching.003.patch > > > As per the discussion on HDFS-4953, we should revisit the zero-copy API to > make it more intuitive for new users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira