[
https://issues.apache.org/jira/browse/HDFS-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778537#comment-13778537
]
Tsz Wo (Nicholas), SZE commented on HDFS-4988:
----------------------------------------------
{quote}
> In new FsVolumeSpi.getStorageID() method, do you want to call it
> getStorageUuid()?
Yes I would like to rename it when we rename it everywhere else. I wanted it to
be consistent as much as possible for now. I filed HDFS-5264 for this.
{quote}
Some parts of the code already are using xxxUuid and some other parts are using
xxxID, I don't see how to make them consistent at the moment. Moreover,
suppose xxxID is a bad name. I don't see the advantage of making things
consistently wrong. So, for the newly added datanodeID/storageID, I suggest to
use datanodeUuid/storageUuid instead of renaming them later. It would also
reduce the size of the future patch in HDFS-5264. Reviewing a large rename
patch is not fun.
It is not a big deal to me. If you insist on this approach, I respect your
decision.
> Datanode must support all the volumes as individual storages
> ------------------------------------------------------------
>
> Key: HDFS-4988
> URL: https://issues.apache.org/jira/browse/HDFS-4988
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Suresh Srinivas
> Assignee: Arpit Agarwal
> Attachments: HDFS-4988.01.patch, HDFS-4988.02.patch,
> HDFS-4988.05.patch, HDFS-4988.06.patch, HDFS-4988.07.patch, HDFS-4988.08.patch
>
>
> Currently all the volumes on datanode is reported as a single storage. This
> change proposes reporting them as individual storage. This requires:
> # A unique storage ID for each storage
> #* This needs to be generated during formatting
> # There should be an option to allow existing disks to be reported as single
> storage unit for backward compatibility.
> # A functionality is also needed to split the existing all volumes as single
> storage unit to to individual storage units.
> # -Configuration must allow for each storage unit a storage type attribute.
> (Now HDFS-5000)-
> # Block reports must be sent on a per storage basis. In some cases (such
> memory tier) block reports may need to be sent more frequently. That means
> block reporting period must be on a per storage type basis.
> My proposal is for new clusters to configure volumes by default as separate
> storage unit. Lets discuss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
