[ 
https://issues.apache.org/jira/browse/HDFS-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HDFS-5279:
--------------------------------

    Attachment: HDFS-5279.1.patch

I'm attaching a patch to add guards against a null {{FSNamesystem}}.  I did a 
full review of the JSP pages, and I think this patch covers everything.  I also 
skipped rendering the "Browse filesystem" hyperlink when the {{FSNamesystem}} 
is null, because there is no way for that page to do anything meaningful before 
initialization of the {{FSNamesystem}}.  I've added several tests that pass 
null to the {{NamenodeJspHelper}} methods.  I also manually tested a browser 
opening all of these pages before the {{FSNamesystem}} is initialized.

> Guard against NullPointerException in NameNode JSP pages before 
> initialization of FSNamesystem.
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5279
>                 URL: https://issues.apache.org/jira/browse/HDFS-5279
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.1.1-beta
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5279.1.patch
>
>
> HDFS-4372 added tracking of NameNode startup progress.  As part of that 
> change, the NameNode HTTP server now starts before initialization of the 
> {{FSNamesystem}}.  There are a few code paths remaining in the JSP pages that 
> are at risk of causing {{NullPointerException}} if accessed when the 
> {{FSNamesystem}} has not been fully initialized.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to