[ 
https://issues.apache.org/jira/browse/HDFS-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782339#comment-13782339
 ] 

Daryn Sharp commented on HDFS-4511:
-----------------------------------

TestDelegationTokenRemoteFetcher:
# Don't hardcode a port number, it prevents concurrent test execution on the 
same host
# Negative cases are only checking for a non-IOException.  If it erroneously 
succeeds, the test doesn't appear to fail
# The tests with a mocked up NIO http server appear to only test that the 
client contacted the server.  It just returns canned responses irregardless of 
the actual request made.  Ie. it doesn't check that the client sent the correct 
parameters, esp. the correct token in the correct format.


> Cover package org.apache.hadoop.hdfs.tools with unit test
> ---------------------------------------------------------
>
>                 Key: HDFS-4511
>                 URL: https://issues.apache.org/jira/browse/HDFS-4511
>             Project: Hadoop HDFS
>          Issue Type: Test
>    Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
>            Reporter: Vadim Bondarev
>         Attachments: HADOOP-4511-branch-0.23-a.patch, 
> HADOOP-4511-branch-2-a.patch, HADOOP-4511-trunk-a.patch, 
> HDFS-4511-branch-2--N2.patch, HDFS-4511-trunk--N4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to