[
https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782414#comment-13782414
]
Junping Du commented on HDFS-4885:
----------------------------------
Thanks Luke for suggestion here. That's definitely much better.
For BlockPlacementStatus, I think it could contains two field like below
{code}
int misReplicated
String misRepInfo
{code}
So the first field can replace current missingRacks to make sure no loss info
and second field is used in NamenodeFsck to add into print directly.
For BlockPlacementConstraints, I'd like to design it as a POJO, and different
BlockPlacementPolicy get different properties here like BPPDefault get minRacks
and BPPWithNodeGroup get minRacks and minNodeGroups.
How does it sounds like?
> Update verifyBlockPlacement() API in BlockPlacementPolicy
> ---------------------------------------------------------
>
> Key: HDFS-4885
> URL: https://issues.apache.org/jira/browse/HDFS-4885
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Junping Du
> Labels: BlockPlacementPolicy
> Attachments: HDFS-4885.patch
>
>
> verifyBlockPlacement() has unused parameter -srcPath as its responsibility
> just verify single block rather than files under a specific path. Also the
> return value (int) does not make sense as the violation of block placement
> has other case than number of racks, so boolean value should be better.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
