[
https://issues.apache.org/jira/browse/HDFS-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5119:
--------------------------------
Hadoop Flags: Reviewed
+1 for the patch, after addressing one minor thing in the JavaDoc shown below.
{{unprotectedAddCachePool}} is an "add" method, but the JavaDoc says "remove".
Please feel free to commit after changing that.
Thank you for addressing all of the feedback.
{code}
/**
* Internal unchecked method used to remove a CachePool. Called directly when
* reloading CacheManager state from the FSImage or edit log.
*
* @param pool to be added
*/
void unprotectedAddCachePool(CachePool pool) {
{code}
> Persist CacheManager state in the edit log
> ------------------------------------------
>
> Key: HDFS-5119
> URL: https://issues.apache.org/jira/browse/HDFS-5119
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS-4949
> Reporter: Colin Patrick McCabe
> Assignee: Andrew Wang
> Attachments: hdfs-5119-1.patch, hdfs-5119-2.patch, hdfs-5119-3.patch
>
>
> CacheManager state should be persisted in the edit log. At the moment, this
> state consists of information about cache pools and cache directives. It's
> not necessary to persist any information about what is cached on the
> DataNodes at any particular moment, since this changes all the time.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
