[ https://issues.apache.org/jira/browse/HDFS-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787819#comment-13787819 ]
Jing Zhao commented on HDFS-5259: --------------------------------- The new patch looks pretty good to me. Only some nits: # Maybe we do not need this part of code: {code} + byte[] fullData = request.getData().array(); + ByteBuffer appendedData = ByteBuffer.wrap(fullData, + (int) (cachedOffset - offset), (int) smallerCount); + appendedData.asReadOnlyBuffer(); {code} # Add VisibleForTesting annotation to WriteCtx@getData(). +1 after addressing the comments. > Support client which combines appended data with old data before sends it to > NFS server > --------------------------------------------------------------------------------------- > > Key: HDFS-5259 > URL: https://issues.apache.org/jira/browse/HDFS-5259 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs > Reporter: Yesha Vora > Assignee: Brandon Li > Attachments: HDFS-5259.000.patch, HDFS-5259.001.patch, > HDFS-5259.003.patch, HDFS-5259.004.patch, HDFS-5259.005.patch, > HDFS-5259.006.patch > > > The append does not work with some Linux client. The Client gets > "Input/output Error" when it tries to append. And NFS server considers it as > random write and fails the request. -- This message was sent by Atlassian JIRA (v6.1#6144)