[ 
https://issues.apache.org/jira/browse/HDFS-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788637#comment-13788637
 ] 

Colin Patrick McCabe commented on HDFS-5224:
--------------------------------------------

I don't have a super-strong opinion about this, but I like Andrew's proposal to 
have a getter that returns a Path in the {{PathBasedCacheDescriptor}}.

bq. While folks chew on this a little more, I'll get started on the builder 
code itself. It sounds like everyone is in agreement on that part.

Yeah, a factory would be good.

> Refactor PathBasedCache* methods to use a Path rather than a String
> -------------------------------------------------------------------
>
>                 Key: HDFS-5224
>                 URL: https://issues.apache.org/jira/browse/HDFS-5224
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-4949
>            Reporter: Andrew Wang
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5224.1.patch
>
>
> As discussed in HDFS-5213, we should refactor PathBasedCacheDirective and 
> related methods in DistributedFileSystem to use a Path to represent paths to 
> cache, rather than a String.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to