[
https://issues.apache.org/jira/browse/HDFS-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797164#comment-13797164
]
Hudson commented on HDFS-5283:
------------------------------
SUCCESS: Integrated in Hadoop-trunk-Commit #4612 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/4612/])
Add TestOpenFilesWithSnapshot.java for HDFS-5283. (szetszwo:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1532860)
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestOpenFilesWithSnapshot.java
HDFS-5283. Under construction blocks only inside snapshots should not be
counted in safemode threshhold. Contributed by Vinay (szetszwo:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1532857)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
> NN not coming out of startup safemode due to under construction blocks only
> inside snapshots also counted in safemode threshhold
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-5283
> URL: https://issues.apache.org/jira/browse/HDFS-5283
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 3.0.0, 2.1.1-beta
> Reporter: Vinay
> Assignee: Vinay
> Priority: Blocker
> Fix For: 2.3.0
>
> Attachments: HDFS-5283.000.patch, HDFS-5283.patch, HDFS-5283.patch,
> HDFS-5283.patch, HDFS-5283.patch, HDFS-5283.patch, HDFS-5283.patch
>
>
> This is observed in one of our env:
> 1. A MR Job was running which has created some temporary files and was
> writing to them.
> 2. Snapshot was taken
> 3. And Job was killed and temporary files were deleted.
> 4. Namenode restarted.
> 5. After restart Namenode was in safemode waiting for blocks
> Analysis
> ---------
> 1. Since the snapshot taken also includes the temporary files which were
> open, and later original files are deleted.
> 2. UnderConstruction blocks count was taken from leases. not considered the
> UC blocks only inside snapshots
> 3. So safemode threshold count was more and NN did not come out of safemode
--
This message was sent by Atlassian JIRA
(v6.1#6144)
