[ https://issues.apache.org/jira/browse/HDFS-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802422#comment-13802422 ]
Eli Collins commented on HDFS-5256: ----------------------------------- - How does testEviction test eviction? It sets a max cache size of 2 and only ever caches one entry? - Nit: clientCache is overloaded as both an integer and a LoadingCache object in the constructor - Nit: Spelling mistake in "clientRemovealListener" > Use guava LoadingCache to implement DFSClientCache > -------------------------------------------------- > > Key: HDFS-5256 > URL: https://issues.apache.org/jira/browse/HDFS-5256 > Project: Hadoop HDFS > Issue Type: Improvement > Components: nfs > Reporter: Haohui Mai > Assignee: Haohui Mai > Fix For: 2.2.0 > > Attachments: HDFS-5256.000.patch, HDFS-5256.001.patch, > HDFS-5256.002.patch, HDFS-5256.003.patch, HDFS-5256.004.patch > > > Google Guava provides an implementation of LoadingCache. Use the LoadingCache > to implement DFSClientCache in NFS. -- This message was sent by Atlassian JIRA (v6.1#6144)