[ https://issues.apache.org/jira/browse/HDFS-5504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820426#comment-13820426 ]
Hadoop QA commented on HDFS-5504: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613367/HDFS-5504.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5399//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5399//console This message is automatically generated. > In HA mode, OP_DELETE_SNAPSHOT is not decrementing the safemode threshold, > leads to NN safemode. > ------------------------------------------------------------------------------------------------ > > Key: HDFS-5504 > URL: https://issues.apache.org/jira/browse/HDFS-5504 > Project: Hadoop HDFS > Issue Type: Bug > Components: snapshots > Affects Versions: 3.0.0, 2.2.0 > Reporter: Vinay > Assignee: Vinay > Attachments: HDFS-5504.patch > > > 1. HA installation, standby NN is down. > 2. delete snapshot is called and it has deleted the blocks from blocksmap and > all datanodes. log sync also happened. > 3. before next log roll NN crashed > 4. When the namenode restartes then it will fsimage and finalized edits from > shared storage and set the safemode threshold. which includes blocks from > deleted snapshot also. (because this edits is not yet read as namenode is > restarted before the last edits segment is not finalized) > 5. When it becomes active, it finalizes the edits and read the delete > snapshot edits_op. but at this time, it was not reducing the safemode count. > and it will continuing in safemode. > 6. On next restart, as the edits is already finalized, on startup only it > will read and set the safemode threshold correctly. > But one more restart will bring NN out of safemode. -- This message was sent by Atlassian JIRA (v6.1#6144)