[ https://issues.apache.org/jira/browse/HDFS-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820877#comment-13820877 ]
Hadoop QA commented on HDFS-5366: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613472/HDFS-5366.006.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5409//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5409//console This message is automatically generated. > recaching improvements > ---------------------- > > Key: HDFS-5366 > URL: https://issues.apache.org/jira/browse/HDFS-5366 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Affects Versions: 3.0.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-5366-caching.001.patch, HDFS-5366.002.patch, > HDFS-5366.005.patch, HDFS-5366.007.patch > > > There are a few things about our HDFS-4949 recaching strategy that could be > improved. > * We should monitor the DN's maximum and current mlock'ed memory consumption > levels, so that we don't ask the DN to do stuff it can't. > * We should not try to initiate caching on stale or decomissioning DataNodes > (although we should not recache things stored on such nodes until they're > declared dead). > * We might want to resend the {{DNA_CACHE}} or {{DNA_UNCACHE}} command a few > times before giving up. Currently, we only send it once. -- This message was sent by Atlassian JIRA (v6.1#6144)