[ https://issues.apache.org/jira/browse/HDFS-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824149#comment-13824149 ]
Hadoop QA commented on HDFS-5519: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614134/HDFS-5519.001.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-nfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5451//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5451//console This message is automatically generated. > COMMIT handler should update the commit status after sync > --------------------------------------------------------- > > Key: HDFS-5519 > URL: https://issues.apache.org/jira/browse/HDFS-5519 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: nfs > Reporter: Brandon Li > Assignee: Brandon Li > Priority: Minor > Attachments: HDFS-5519.001.patch, HDFS-5519.patch > > > The problem was found during test with Windows NFS client. > After hsync, OpenFileCtx#checkCommit() should update COMMIT_DO_SYNC to > COMMIT_FINISHED. Otherwise, the caller could throw run time exception since > COMMIT_DO_SYNC is not expected. -- This message was sent by Atlassian JIRA (v6.1#6144)