[
https://issues.apache.org/jira/browse/HDFS-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824926#comment-13824926
]
Hadoop QA commented on HDFS-5372:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614288/HDFS-5372.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5454//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5454//console
This message is automatically generated.
> In FSNamesystem, hasReadLock() returns false if the current thread holds the
> write lock
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-5372
> URL: https://issues.apache.org/jira/browse/HDFS-5372
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: HDFS-5372.patch
>
>
> This bug was discovered by [~vinayrpet] in [this
> comment|https://issues.apache.org/jira/browse/HDFS-5283?focusedCommentId=13796752&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13796752].
> In FSNamesystem, there are hasReadLock() and hasReadOrWriteLock(). However,
> when a thread holds the write lock, the read lock is not required for reading
> data. So hasReadLock() and hasReadOrWriteLock() actually are the same.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
