[
https://issues.apache.org/jira/browse/HDFS-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826061#comment-13826061
]
Hadoop QA commented on HDFS-5512:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614506/hdfs-5512-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5469//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5469//console
This message is automatically generated.
> CacheAdmin -listPools fails with NPE when user lacks permissions to view all
> pools
> ----------------------------------------------------------------------------------
>
> Key: HDFS-5512
> URL: https://issues.apache.org/jira/browse/HDFS-5512
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: caching, tools
> Affects Versions: 3.0.0
> Reporter: Stephen Chu
> Assignee: Andrew Wang
> Attachments: hdfs-5512-1.patch
>
>
> https://issues.apache.org/jira/browse/HDFS-5471 (CacheAdmin -listPools fails
> when user lacks permissions to view all pools) was recently resolved, but on
> a build with this fix, I am running into another error when using cacheadmin
> -listPools.
> Now, when the user does not have permissions to view all the pools, the
> cacheadmin -listPools command will throw a NullPointerException.
> On a system with a single pool "root" with a mode of 750, I see this as user
> schu:
> {code}
> [schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -listPools
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.tools.CacheAdmin$ListCachePoolsCommand.run(CacheAdmin.java:745)
> at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:82)
> at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:87)
> {code}
> After we modify the root pool to 755, then -listPools works properly.
> {code}
> [schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -listPools
> Found 1 result.
> NAME OWNER GROUP MODE WEIGHT
> root root root rwxr-xr-x 100
> [schu@hdfs-c5-nfs ~]$
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
