[ https://issues.apache.org/jira/browse/HDFS-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826246#comment-13826246 ]
Hadoop QA commented on HDFS-5513: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614547/hdfs-5513-2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5476//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5476//console This message is automatically generated. > CacheAdmin commands fail when using . as the path > ------------------------------------------------- > > Key: HDFS-5513 > URL: https://issues.apache.org/jira/browse/HDFS-5513 > Project: Hadoop HDFS > Issue Type: Bug > Components: caching, tools > Affects Versions: 3.0.0 > Reporter: Stephen Chu > Assignee: Andrew Wang > Priority: Minor > Attachments: hdfs-5513-1.patch, hdfs-5513-2.patch > > > The hdfs CLI commands generally accept "." as a path argument. > e.g. > {code} > hdfs dfs -rm . > hdfs dfsadmin -allowSnapshot . > {code} > I don't think it's very common to use the path "." but the CacheAdmin > commands will fail saying that it cannot create a Path from an empty string. > {code} > [schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -removeDirectives -path . > Exception in thread "main" java.lang.IllegalArgumentException: Can not create > a Path from an empty string > at org.apache.hadoop.fs.Path.checkPathArg(Path.java:127) > at org.apache.hadoop.fs.Path.<init>(Path.java:184) > at > org.apache.hadoop.hdfs.protocol.PathBasedCacheDirective$Builder.<init>(PathBasedCacheDirective.java:66) > at > org.apache.hadoop.hdfs.DistributedFileSystem.listPathBasedCacheDirectives(DistributedFileSystem.java:1639) > at > org.apache.hadoop.hdfs.tools.CacheAdmin$RemovePathBasedCacheDirectivesCommand.run(CacheAdmin.java:365) > at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:82) > at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:87) > [schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -addDirective -path . -pool schu > Exception in thread "main" java.lang.IllegalArgumentException: Can not create > a Path from an empty string > at org.apache.hadoop.fs.Path.checkPathArg(Path.java:127) > at org.apache.hadoop.fs.Path.<init>(Path.java:184) > at > org.apache.hadoop.hdfs.protocol.PathBasedCacheDirective$Builder.<init>(PathBasedCacheDirective.java:66) > at > org.apache.hadoop.hdfs.DistributedFileSystem.addPathBasedCacheDirective(DistributedFileSystem.java:1598) > at > org.apache.hadoop.hdfs.tools.CacheAdmin$AddPathBasedCacheDirectiveCommand.run(CacheAdmin.java:180) > at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:82) > at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:87) > {code} -- This message was sent by Atlassian JIRA (v6.1#6144)