[ 
https://issues.apache.org/jira/browse/HDFS-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826528#comment-13826528
 ] 

Alejandro Abdelnur commented on HDFS-3987:
------------------------------------------

Overall approach looks good, a few comments:

* HttpServer.java, the changes here don't seem necessary or do anything
* DFSUtil.java, type in exception message "Unsupported schmeme: "
* SWebHdfsFileSystem.java, why do we need a new token type? What that adds?
* WebHdfsFileSystem.java, it seems things are hardcoded to use a specific token 
kind, it should use the token kind send by the server. My concern here is 
HttpFS tokens. Have you verified HttpFS works with swebhdfs?



> Support webhdfs over HTTPS
> --------------------------
>
>                 Key: HDFS-3987
>                 URL: https://issues.apache.org/jira/browse/HDFS-3987
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.0.2-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Haohui Mai
>             Fix For: 2.3.0
>
>         Attachments: HDFS-3987.000.patch, HDFS-3987.001.patch, 
> HDFS-3987.002.patch, HDFS-3987.003.patch, HDFS-3987.004.patch, 
> HDFS-3987.005.patch, HDFS-3987.006.patch, HDFS-3987.007.patch, 
> HDFS-3987.008.patch
>
>
> This is a follow up of HDFS-3983.
> We should have a new filesystem client impl/binding for encrypted WebHDFS, 
> i.e. *webhdfss://*
> On the server side, webhdfs and httpfs we should only need to start the 
> service on a secured (HTTPS) endpoint.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to