[ https://issues.apache.org/jira/browse/HDFS-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830320#comment-13830320 ]
Hadoop QA commented on HDFS-5537: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615370/HDFS-5537.001.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 10 warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5543//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5543//console This message is automatically generated. > Remove FileWithSnapshot interface > --------------------------------- > > Key: HDFS-5537 > URL: https://issues.apache.org/jira/browse/HDFS-5537 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-5537.000.patch, HDFS-5537.001.patch > > > We use the FileWithSnapshot interface to define a set of methods shared by > INodeFileWithSnapshot and INodeFileUnderConstructionWithSnapshot. After using > the Under-Construction feature to replace the INodeFileUC and > INodeFileUCWithSnapshot, we no longer need this interface. -- This message was sent by Atlassian JIRA (v6.1#6144)