[
https://issues.apache.org/jira/browse/HDFS-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832172#comment-13832172
]
Hadoop QA commented on HDFS-5549:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615703/HDFS-5549.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5564//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5564//console
This message is automatically generated.
> Support for implementing custom FsDatasetSpi from outside the project
> ---------------------------------------------------------------------
>
> Key: HDFS-5549
> URL: https://issues.apache.org/jira/browse/HDFS-5549
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0
> Reporter: Ignacio Corderi
> Attachments: HDFS-5549.patch
>
>
> Visibility for multiple methods and a few classes got changed to public to
> allow FsDatasetSpi<T> and all the related classes that need subtyping to be
> fully implemented from outside the HDFS project.
> Blocks transfers got abstracted to a factory given that the behavior will be
> changed for DataNodes using Kinetic drives. The existing DataNode to DataNode
> block transfer functionality got moved to LegacyBlockTransferer, no new
> configuration is needed to use this class and have the same behavior that is
> currently present.
> DataNodes have an additional configuration key
> DFS_DATANODE_BLOCKTRANSFERER_FACTORY_KEY to override the default block
> transfer behavior.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
